sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Dian Fu" <dian0511...@gmail.com>
Subject Re: Review Request 40635: Sqoop2: Add kerberos support for SqoopMiniCluster
Date Thu, 26 Nov 2015 02:29:45 GMT


> On Nov. 25, 2015, 6 p.m., Jarek Cecho wrote:
> > pom.xml, lines 774-778
> > <https://reviews.apache.org/r/40635/diff/8/?file=1139698#file1139698line774>
> >
> >     I'm not sure what the felix dependency provide us. Would you mind describing
that?

Hadoop-miniKdc depends on "apacheds-jdbm-partition" and "apacheds-jdbm-partition" depends
on "apacheds-jdbm1" and the depending type is marked as "bundle" as "apacheds-jdbm1" is a
OSGI bundle. Maven-bundle-plugin is required to do the proper mapping with the filenames during
compile. This link[1] has detailed information about this:
[1] http://mail-archives.apache.org/mod_mbox/directory-users/201307.mbox/%3C6BA66FEF-30F8-4E8F-A171-8D01870AA1B0@marcelot.net%3E


> On Nov. 25, 2015, 6 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java, line
202
> > <https://reviews.apache.org/r/40635/diff/8/?file=1139707#file1139707line202>
> >
> >     Shouldn't we be checking the provider rather then a UtilClass here?

What do you mean by "provider"? Do you mean by checking "KdcInfrastructureProvider"? If so,
this isn't doable as "Infrastructure" is only used in part of the integration tests (inheritted
from SqoopTestCase). The other part of the integration tests (inheritted from JettyTestCase)
don't use the "Infrastructure". Thoughts?


> On Nov. 25, 2015, 6 p.m., Jarek Cecho wrote:
> > test/src/main/java/org/apache/sqoop/test/utils/KerberosTestUtils.java, lines 155-166
> > <https://reviews.apache.org/r/40635/diff/8/?file=1139709#file1139709line155>
> >
> >     This seems very fragile approach. Is there a reason why in case of MiniKdc we're
not loading generated credentials to the JVM itsemf? This way we would not have to do any
"hacks" to propagate the security context and at the same time we would emulate what's gonna
happen in real production environments.

Would you mind describing more detailly about loading the credentials to the JVM? I'm not
clear about this. Thanks a lot.


- Dian


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40635/#review108018
-----------------------------------------------------------


On Nov. 25, 2015, 4:50 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40635/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2015, 4:50 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2705
>     https://issues.apache.org/jira/browse/SQOOP-2705
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> At the first step of providing kerberos support for integration tests, I'd like to add
kerberos support for SqoopMiniCluster make sure the communication between sqoop client and
sqoop server are kerberos enabled.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/SqoopClient.java 3d3425d 
>   client/src/main/java/org/apache/sqoop/client/request/SqoopResourceRequests.java 0987703

>   pom.xml 91721ce 
>   test/pom.xml 4e1e197 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 4c5d3a8

>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/KdcInfrastructureProvider.java
PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/kdc/KdcRunnerFactory.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/kdc/RealKdcRunner.java PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniCluster.java 325a790

>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 9ae941f

>   test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java bd4ba6a 
>   test/src/main/java/org/apache/sqoop/test/utils/KerberosTestUtils.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/server/InformalObjectNameTest.java
920679f 
>   test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java cbf1e90

>   test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
9e682bc 
>   test/src/test/java/org/apache/sqoop/integration/server/VersionTest.java e86a6cc 
>   test/src/test/java/org/apache/sqoop/integration/server/rest/LinkRestTest.java 99959ac

>   test/src/test/java/org/apache/sqoop/integration/server/rest/RestTest.java 4ac564c 
> 
> Diff: https://reviews.apache.org/r/40635/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message