sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 40735: SQOOP-2715: Sqoop2: The test case ShowJobInOrderTest always failed
Date Mon, 30 Nov 2015 17:07:09 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/40735/#review108325
-----------------------------------------------------------


It seems that we've added the test ShowJobInOrderTest back in SQOOP-2398, but sadly the description
of the JIRA is very sparse.  I'm not clear why we actually added it as we don't have any guarantees
in terms of ordering on the REST interface.

Nevertheless it seems that the issue is that we're comparing persistence ID and we are assuming
completely new database at the begging (e.g. all incremental columns to start from 1). That
is incorrect assumption and comparison as a) we're droopping the ID's completely and b) in
case that we're running the test case against real database (MySQL, PostgreSQL) it will never
be true.

So, what about fixing it properly? Rather then keeing the now-not-public Ids what about setting
jobName() properly and compare that instead?

- Jarek Cecho


On Nov. 26, 2015, 8:14 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/40735/
> -----------------------------------------------------------
> 
> (Updated Nov. 26, 2015, 8:14 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> ShowJobInOrderTest always thrown the exception during the test, because the DatabaseInfrastructureProvider
is shared with all tests case in one suite.
> 
> 
> Diffs
> -----
> 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java 4c5d3a8

>   test/src/test/java/org/apache/sqoop/integration/server/ShowJobInOrderTest.java cbf1e90

> 
> Diff: https://reviews.apache.org/r/40735/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message