sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Fine" <abef...@cloudera.com>
Subject Re: Review Request 41887: SQOOP-2768 Sqoop2: Remove the notion of LinksBeans
Date Tue, 05 Jan 2016 20:19:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41887/#review112920
-----------------------------------------------------------

Ship it!


Ship It!

- Abraham Fine


On Jan. 4, 2016, 6:54 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41887/
> -----------------------------------------------------------
> 
> (Updated Jan. 4, 2016, 6:54 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2768
>     https://issues.apache.org/jira/browse/SQOOP-2768
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I've removed the LinksBeans class as suggested on JIRA.
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java 2b19dac

>   common/src/main/java/org/apache/sqoop/json/LinkBean.java 8ce8b2b 
>   common/src/main/java/org/apache/sqoop/json/LinksBean.java 87e873d 
>   common/src/test/java/org/apache/sqoop/json/TestLinkBean.java 0df0f9d 
>   common/src/test/java/org/apache/sqoop/json/TestLinksBean.java 0ee29fa 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java 9f6ed90 
>   test/src/test/java/org/apache/sqoop/integration/tools/RepositoryDumpLoadToolTest.java
03d4a9f 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryDumpTool.java 6958ee1 
>   tools/src/main/java/org/apache/sqoop/tools/tool/RepositoryLoadTool.java 748ef80 
> 
> Diff: https://reviews.apache.org/r/41887/diff/
> 
> 
> Testing
> -------
> 
> Unit tests are passing on my box, I did not run integration tests (will be done by precommit
hook).
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message