sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jarek Cecho" <jar...@apache.org>
Subject Re: Review Request 41971: Sqoop2: Enable kerberos for HadoopMiniCluster
Date Wed, 06 Jan 2016 16:07:07 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41971/#review113083
-----------------------------------------------------------


Overall the patch looks good to me. I have one question and then we need to get the precommit
hook passing.


test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java (line 74)
<https://reviews.apache.org/r/41971/#comment173597>

    Why do we need to change the directory to /tmp/ ?
    
    Aren't we by mistake using this for local path somewhere?


Jarcec

- Jarek Cecho


On Jan. 6, 2016, 7:28 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41971/
> -----------------------------------------------------------
> 
> (Updated Jan. 6, 2016, 7:28 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2744
>     https://issues.apache.org/jira/browse/SQOOP-2744
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> The aim of this JIRA is to enable kerberos for HadoopMiniCluster.
> 
> 
> Diffs
> -----
> 
>   test/pom.xml bd1680f 
>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopMiniClusterRunner.java 2c0c4e6

>   test/src/main/java/org/apache/sqoop/test/hadoop/HadoopRunner.java cb4e384 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java c300b33

>   test/src/main/java/org/apache/sqoop/test/kdc/KdcRunner.java aa5c6fc 
>   test/src/main/java/org/apache/sqoop/test/kdc/MiniKdcRunner.java 299fd9f 
>   test/src/main/java/org/apache/sqoop/test/kdc/NoKerberosKdcRunner.java 29a005e 
>   test/src/main/java/org/apache/sqoop/test/minicluster/SqoopMiniCluster.java 4ff97e7

>   test/src/main/java/org/apache/sqoop/test/testcases/JettyTestCase.java d4ca396 
>   test/src/test/java/org/apache/sqoop/integration/connector/hive/FromRDBMSToKiteHiveTest.java
ec9f733 
>   test/src/test/resources/hive-tests-suite.xml PRE-CREATION 
>   test/src/test/resources/integration-tests-suite.xml 1cf3299 
> 
> Diff: https://reviews.apache.org/r/41971/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message