sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Fine" <abef...@cloudera.com>
Subject Re: Review Request 41910: SQOOP-2758: Sqoop2: Add integration test for shell
Date Wed, 13 Jan 2016 22:11:01 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41910/#review114270
-----------------------------------------------------------



test/src/main/java/org/apache/sqoop/test/testcases/ShellTestCase.java (line 41)
<https://reviews.apache.org/r/41910/#comment175084>

    why do we need this. shouldn't all tests run against a clean repository?



test/src/main/java/org/apache/sqoop/test/testcases/ShellTestCase.java (line 81)
<https://reviews.apache.org/r/41910/#comment175083>

    perhaps outside the scope of this jira, but does this really belong here?
    
    creating a link seems like something that belongs in the more general SqoopTestCase class



test/src/test/java/org/apache/sqoop/integration/shell/CloneCommandTest.java (line 56)
<https://reviews.apache.org/r/41910/#comment175080>

    typo :)



test/src/test/java/org/apache/sqoop/integration/shell/CloneCommandTest.java (line 60)
<https://reviews.apache.org/r/41910/#comment175081>

    why the new lines?


- Abraham Fine


On Jan. 13, 2016, 7:38 a.m., Colin Ma wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41910/
> -----------------------------------------------------------
> 
> (Updated Jan. 13, 2016, 7:38 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> For the test of shell, currently, too many mock in test cases, and some bugs won't be
detected. The integration test should be added for shell, and do the test with sqoop server.
> 
> 
> Diffs
> -----
> 
>   shell/src/main/java/org/apache/sqoop/shell/SetCommand.java 0a04e3d 
>   shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java c148eeb 
>   shell/src/main/java/org/apache/sqoop/shell/StartCommand.java 679c1f7 
>   shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java 6082799 
>   shell/src/main/java/org/apache/sqoop/shell/StopCommand.java 83c571a 
>   test/pom.xml bd1680f 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/SqoopTestCase.java becfa6b

>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProvider.java
4d51ed6 
>   test/src/main/java/org/apache/sqoop/test/infrastructure/providers/SqoopInfrastructureProviderForShellTest.java
PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/minicluster/JettySqoopMiniClusterWithExternalConnector.java
PRE-CREATION 
>   test/src/main/java/org/apache/sqoop/test/testcases/ConnectorClasspathTestCase.java
6db1db8 
>   test/src/main/java/org/apache/sqoop/test/testcases/ShellTestCase.java PRE-CREATION

>   test/src/main/java/org/apache/sqoop/test/utils/ConnectorUtils.java PRE-CREATION 
>   test/src/test/java/org/apache/sqoop/integration/connectorloading/ClasspathTest.java
4bb6aa1 
>   test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java
5b95631 
>   test/src/test/java/org/apache/sqoop/integration/server/SubmissionWithDisabledModelObjectsTest.java
9adebea 
>   test/src/test/java/org/apache/sqoop/integration/shell/CloneCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/CreateCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/DeleteCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/DisableCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/EnableCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/SetCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/ShowCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/StartCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/StatusCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/StopCommandTest.java PRE-CREATION

>   test/src/test/java/org/apache/sqoop/integration/shell/UpdateCommandTest.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestConnectorForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestExtractorForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestFromDestroyerForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestFromInitializerForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestFromJobConfigForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestFromJobConfigurationForShell.java
PRE-CREATION 
>   test/src/test/resources/TestConnectorForShell/TestLinkConfigForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestLinkConfigurationForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestLoaderForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestPartitionForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestPartitionerForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestToDestroyerForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestToInitializerForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestToJobConfigForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/TestToJobConfigurationForShell.java PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/sqoopconnector.properties PRE-CREATION

>   test/src/test/resources/TestConnectorForShell/test-connector-for-shell.properties PRE-CREATION

>   test/src/test/resources/shell-tests-suite.xml PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/41910/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Colin Ma
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message