sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Abraham Fine" <...@abrahamfine.com>
Subject Re: Review Request 42495: SQOOP-2796: Sqoop2: Add cmd tool to automate patch upload process
Date Wed, 20 Jan 2016 23:29:31 GMT


> On Jan. 19, 2016, 6:52 p.m., Abraham Fine wrote:
> > dev-support/upload-patch.py, line 226
> > <https://reviews.apache.org/r/42495/diff/1/?file=1201503#file1201503line226>
> >
> >     perhaps it should be an option to make the changes public by default rather
than just doing it.
> 
> Jarek Cecho wrote:
>     I was thinking about this one myself. The reason why I did not do it at this point
is that the scripts is straighforward. Generate patch -> upload to review board -> update
JIRA. If the review haven't been published, then it doesn't make sense to continue in the
next steps. Perhaps we can do "review board only" mode, would that be helpful?

i agree, since we are uploading the new patch to jira it does not make sense to prevent rb
from being made visisble.


- Abraham


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42495/#review115211
-----------------------------------------------------------


On Jan. 19, 2016, 11:13 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42495/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2016, 11:13 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2796
>     https://issues.apache.org/jira/browse/SQOOP-2796
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Our process to submit a contribution to Sqoop has quite a few steps:
> 
> # Clone repo
> # Work on the fix/feature/...
> # Generate text patch
> # Upload it to review board
> # Don't forget to publish the review board
> # Upload the patch to JIRA
> # Switch the JIRA to "Patch available"
> 
> Forgetting to do any of those steps will lead to a quite unnecessary delays  with accepting
the patch so I would like to automate steps 3-7 with simple script that one can call from
the computer and all that will happen "magically" automatically.
> 
> 
> Diffs
> -----
> 
>   dev-support/upload-patch.py PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/42495/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message