sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 42066: Sqoop2: Connector isolated class loader should be used when running validations
Date Mon, 25 Jan 2016 21:11:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42066/#review116169
-----------------------------------------------------------



we discussed offline the desired classloader for validators living outside the connector's
jar (such as the ClassAvailable validator).

can this patch be ammended to include tests/changes to support that functionality?

- Abraham Fine


On Jan. 8, 2016, 9:31 a.m., Dian Fu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42066/
> -----------------------------------------------------------
> 
> (Updated Jan. 8, 2016, 9:31 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2781
>     https://issues.apache.org/jira/browse/SQOOP-2781
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> When we run validations on links triggered via the server's request handlers they do
not appear to be run under their connector's isolated classpath. This can lead to the wrong
classes being used (or not found) during validations and incorrect validations.
> 
> 
> Diffs
> -----
> 
>   test/src/test/java/org/apache/sqoop/integration/connectorloading/ConnectorClasspathIsolationTest.java
5b95631 
>   test/src/test/resources/TestConnectorClasspathIsolation/from/TestFromJobConfig.java
PRE-CREATION 
>   test/src/test/resources/TestConnectorClasspathIsolation/from/TestFromJobConfiguration.java
00d34b4 
>   test/src/test/resources/TestConnectorClasspathIsolation/from/TestValidator.java PRE-CREATION

>   test/src/test/resources/TestConnectorClasspathIsolation/to/TestToJobConfig.java PRE-CREATION

>   test/src/test/resources/TestConnectorClasspathIsolation/to/TestToJobConfiguration.java
ff1c3ed 
>   test/src/test/resources/TestConnectorClasspathIsolation/to/TestValidator.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/42066/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Dian Fu
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message