sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-2795) Clean up useless code in class TestSqoopJsonUtil
Date Mon, 25 Jan 2016 22:50:39 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-2795?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15116230#comment-15116230
] 

Hudson commented on SQOOP-2795:
-------------------------------

FAILURE: Integrated in Sqoop-hadoop100 #997 (See [https://builds.apache.org/job/Sqoop-hadoop100/997/])
SQOOP-2795: Clean up useless code in class TestSqoopJsonUtil (jarcec: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=de2fa9a68654a90f91d85286504d2da161975a4f])
* src/test/org/apache/sqoop/util/TestSqoopJsonUtil.java
* src/java/org/apache/sqoop/util/SqoopJsonUtil.java


> Clean up useless code in class TestSqoopJsonUtil
> ------------------------------------------------
>
>                 Key: SQOOP-2795
>                 URL: https://issues.apache.org/jira/browse/SQOOP-2795
>             Project: Sqoop
>          Issue Type: Improvement
>    Affects Versions: 1.4.6
>            Reporter: Ze Jin
>            Assignee: Ze Jin
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 1.4.7
>
>         Attachments: SQOOP-2795.0000.patch, SQOOP-2795.0001.patch
>
>
> The import in line 7 is never used. The field in line 13 is not used, and methods in
class SqoopJsonUtil are all static, so any intance of SqoopJsonUtil is unnecessary.
> According to Sonar rule squid:S1118 - Utility classes should not have public constructors
> You can find more information about the issue here:
> https://dev.eclipse.org/sonar/coding_rules#q=squid:S1118



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message