sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Colin Ma <junjie...@intel.com>
Subject Re: Review Request 43171: SQOOP-2819: Use connector name instead of id in Repository.findJobsForConnector methods
Date Sat, 06 Feb 2016 06:29:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43171/#review118138
-----------------------------------------------------------


Ship it!




Ship It!

- Colin Ma


On Feb. 4, 2016, 1:43 a.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43171/
> -----------------------------------------------------------
> 
> (Updated Feb. 4, 2016, 1:43 a.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2819
>     https://issues.apache.org/jira/browse/SQOOP-2819
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> In SQOOP-2573 we've migrated {{Repository. findLinksForConnectorUpgrade}} and {{Repository.
findLinksForConnector}} to use name instead of id. it seems that we forgot to do the same
for {{Repository. findJobsForConnectorUpgrade}} and {{Repository. findJobsForConnector}} though.
> 
> 
> Diffs
> -----
> 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java 1b7cd2e 
>   core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java 7047be9 
>   core/src/main/java/org/apache/sqoop/repository/Repository.java 1f7bcfd 
>   core/src/test/java/org/apache/sqoop/repository/TestJdbcRepository.java d26ce71 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryHandler.java
5490324 
>   repository/repository-common/src/main/java/org/apache/sqoop/repository/common/CommonRepositoryInsertUpdateDeleteSelectQuery.java
58404d7 
>   repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
ad8946b 
>   repository/repository-mysql/src/test/java/org/apache/sqoop/integration/repository/mysql/TestJobHandling.java
9109212 
>   repository/repository-postgresql/src/test/java/org/apache/sqoop/integration/repository/postgresql/TestJobHandling.java
6636bd3 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java 9dfcb0b 
> 
> Diff: https://reviews.apache.org/r/43171/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message