sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarek Cecho <jar...@apache.org>
Subject Re: Review Request 43467: SQOOP-2832: Sqoop2: Precommit: Create log files for individual tests
Date Fri, 19 Feb 2016 15:32:37 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43467/
-----------------------------------------------------------

(Updated Feb. 19, 2016, 3:32 p.m.)


Review request for Sqoop and Jarek Cecho.


Bugs: SQOOP-2832
    https://issues.apache.org/jira/browse/SQOOP-2832


Repository: sqoop-sqoop2


Description
-------

I feel that debugging anything in our pre-commit hook is currently mission impossible from
several reasons. One of the main ones is that we're generating one single log file that has
[grown to 1GB in size|https://builds.apache.org/job/PreCommit-SQOOP-Build/2185/artifact/test/target/surefire-reports/]
with all "test related" logs and I'm not even remotely able to find anything there.

In normal case we would have one log per test class, but as we've refactored our integration
tests to run multiple classes inside single Suite, we're no longer have that for free. We
have done this change to cut the time it takes to run the integration tests - before we were
initializing mini clusters for each class, which is extra ~40 seconds per class, so I don't
think that reverting it would be reasonable.

We should perhaps explore other ways how to get multiple log files.


Diffs (updated)
-----

  test/pom.xml 134bca1 
  test/src/main/java/org/apache/sqoop/test/testng/ReconfigureLogListener.java PRE-CREATION

  test/src/test/resources/connector-loading-tests-suite.xml 02c1df3 
  test/src/test/resources/hive-tests-suite.xml 3e2b328 
  test/src/test/resources/integration-tests-suite.xml 73e0a77 
  test/src/test/resources/new-integration-tests-suite.xml 96a1320 
  test/src/test/resources/shell-tests-suite.xml e2c0b09 
  test/src/test/resources/tools-tests-suite.xml fee2121 
  test/src/test/resources/upgrade-tests-suite.xml 3318e67 

Diff: https://reviews.apache.org/r/43467/diff/


Testing
-------


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message