sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 43857: SQOOP-2545: Sqoop2: RESTiliency: Provide tests for non-existing end points
Date Tue, 01 Mar 2016 20:07:35 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43857/#review121482
-----------------------------------------------------------




server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 
<https://reviews.apache.org/r/43857/#comment183197>

    why is this change only being made for the submissionrequesthandler?
    
    don't we have something similar for the driverrequesthandler?



server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java (line 144)
<https://reviews.apache.org/r/43857/#comment183196>

    perhaps there is a better way of handling this. i can imagine multiple different servererrors
mapping to different http status codes.
    
    I would understand if you felt that this would be best suited for a different jira.


- Abraham Fine


On Feb. 24, 2016, 11:26 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43857/
> -----------------------------------------------------------
> 
> (Updated Feb. 24, 2016, 11:26 p.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2545
>     https://issues.apache.org/jira/browse/SQOOP-2545
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I would like to see (&test) what happens when I call some random non-existing REST
URLs to our server.
> 
> 
> Diffs
> -----
> 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java b894e37

>   server/src/main/java/org/apache/sqoop/server/SqoopProtocolServlet.java fb4a99f 
>   test/src/test/java/org/apache/sqoop/integration/server/rest/ConnectorRestTest.java
839a4d0 
>   test/src/test/java/org/apache/sqoop/integration/server/rest/NonExistingRestTest.java
PRE-CREATION 
>   test/src/test/java/org/apache/sqoop/integration/server/rest/VersionRestTest.java e4c89df

> 
> Diff: https://reviews.apache.org/r/43857/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message