sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarek Cecho <jar...@apache.org>
Subject Review Request 44302: SQOOP-2864 ClassWriter chokes on column names containing double quotes
Date Wed, 02 Mar 2016 22:49:50 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44302/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-2864
    https://issues.apache.org/jira/browse/SQOOP-2864


Repository: sqoop-trunk


Description
-------

I've added code that is specifically handling double quotes. I'm anticipating that we might
need to extend it in the future with more prolematic characters as we find out what else are
popular RDBMS allowing.


Diffs
-----

  src/java/org/apache/sqoop/orm/ClassWriter.java 95c655d 

Diff: https://reviews.apache.org/r/44302/diff/


Testing
-------

Creating automated test for this one is super problematical because the build-in HSQDB that
we're using for testing doesn't support double quotes in column names. I did however tested
the code on real cluster against MySQL.


Thanks,

Jarek Cecho


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message