sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 44410: SQOOP-2870: Sqoop2: RESTiliency: Add tests for DriverHandler
Date Mon, 07 Mar 2016 21:03:48 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44410/#review122375
-----------------------------------------------------------




test/src/test/java/org/apache/sqoop/integration/server/rest/DriverRestTest.java (lines 29
- 33)
<https://reviews.apache.org/r/44410/#comment184327>

    perhaps there would be value in testing the contents of the response somehow?
    
    is there some text that we know would always be in the serialized version of the driver?


- Abraham Fine


On March 4, 2016, 11:23 p.m., Jarek Cecho wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44410/
> -----------------------------------------------------------
> 
> (Updated March 4, 2016, 11:23 p.m.)
> 
> 
> Review request for Sqoop and Jarek Cecho.
> 
> 
> Bugs: SQOOP-2870
>     https://issues.apache.org/jira/browse/SQOOP-2870
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> I would like to addd small test case covering {{DriverHandler}} module similarly as we're
building for other REST endpoints.
> 
> 
> Diffs
> -----
> 
>   server/src/main/java/org/apache/sqoop/handler/DriverRequestHandler.java 95a3291 
>   test/src/test/java/org/apache/sqoop/integration/server/rest/DriverRestTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/44410/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Jarek Cecho
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message