sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarek Cecho <jar...@apache.org>
Subject Re: Review Request 44316: Fix For Issue SQOOP-2846
Date Mon, 21 Mar 2016 15:49:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44316/#review124560
-----------------------------------------------------------




src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java (line 233)
<https://reviews.apache.org/r/44316/#comment187177>

    Nit: Trailing whitespace.


- Jarek Cecho


On March 3, 2016, 7:05 a.m., vishnu  s nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44316/
> -----------------------------------------------------------
> 
> (Updated March 3, 2016, 7:05 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2846
>     https://issues.apache.org/jira/browse/SQOOP-2846
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> After analyzing the issue, it is found that export with update key is
> not implemneted properly in case of avro and parqute file formats.
> In order to correct the issue SQOOP-2846, export with update option is
> implemented for the mentioned file formats. For this appropriate
> mapper, input format and output format classes were used in the
> implementation.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/JdbcUpdateExportJob.java 8fa420e 
>   src/test/com/cloudera/sqoop/TestAvroExport.java 137a6e1 
>   src/test/com/cloudera/sqoop/TestParquetExport.java 86b40fb 
>   src/test/com/cloudera/sqoop/testutil/ExportJobTestCase.java 9a6e8da 
> 
> Diff: https://reviews.apache.org/r/44316/diff/
> 
> 
> Testing
> -------
> 
> Updated test cases were executed successfully and the same is also
> incorporated in the patch.
> 
> 
> Thanks,
> 
> vishnu  s nair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message