sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From vishnu s nair <vishnusn2...@gmail.com>
Subject Re: Review Request 44317: SQOOP-2561
Date Mon, 28 Mar 2016 10:45:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44317/
-----------------------------------------------------------

(Updated March 28, 2016, 10:45 a.m.)


Review request for Sqoop.


Changes
-------

Indentation Issue. There is no whitespace while we are opening this files in notepad. But
while checking difference in review board , we can see an wxtra white sapce. Kindly check
the same


Bugs: SQOOP-2561
    https://issues.apache.org/jira/browse/SQOOP-2561


Repository: sqoop-trunk


Description
-------

Special Character removal from Column name as avro data results in
duplicate column and fails the import

Solution:  Instead of removing the special character, replace it with
underscore


Diffs
-----

  src/java/org/apache/sqoop/avro/AvroUtil.java 90cc9d0 
  src/test/com/cloudera/sqoop/TestAvroImport.java 00d7a95 

Diff: https://reviews.apache.org/r/44317/diff/


Testing
-------

Test case for the same is exceuted successfully.


File Attachments (updated)
----------------

0001-SQOOP-2561.patch
  https://reviews.apache.org/media/uploaded/files/2016/03/28/b4e6e0be-148e-4b59-9a7c-116bce192633__0001-SQOOP-2561.patch


Thanks,

vishnu  s nair


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message