sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jarek Cecho <jar...@apache.org>
Subject Re: Review Request 44317: SQOOP-2561
Date Mon, 28 Mar 2016 16:11:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44317/#review125663
-----------------------------------------------------------



Thanks for fixing the indendation problem VISHNU!

I've run the latest patch that is available on the JIRA and it seems that it broke another
test:

Testcase: testNonstandardCharactersInColumnName took 1.288 sec
	FAILED
expected:<AVRO[]1> but was:<AVRO[_]1>
junit.framework.ComparisonFailure: expected:<AVRO[]1> but was:<AVRO[_]1>
	at com.cloudera.sqoop.TestAvroImport.checkField(TestAvroImport.java:278)
	at com.cloudera.sqoop.TestAvroImport.testNonstandardCharactersInColumnName(TestAvroImport.java:226)
    
I'm assuming that we just need to fix the expected value as we've change the way we're generating
the column names. Could you take a look?

- Jarek Cecho


On March 28, 2016, 10:45 a.m., vishnu  s nair wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44317/
> -----------------------------------------------------------
> 
> (Updated March 28, 2016, 10:45 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2561
>     https://issues.apache.org/jira/browse/SQOOP-2561
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Special Character removal from Column name as avro data results in
> duplicate column and fails the import
> 
> Solution:  Instead of removing the special character, replace it with
> underscore
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/avro/AvroUtil.java 90cc9d0 
>   src/test/com/cloudera/sqoop/TestAvroImport.java 00d7a95 
> 
> Diff: https://reviews.apache.org/r/44317/diff/
> 
> 
> Testing
> -------
> 
> Test case for the same is exceuted successfully.
> 
> 
> File Attachments
> ----------------
> 
> 0001-SQOOP-2561.patch
>   https://reviews.apache.org/media/uploaded/files/2016/03/28/b4e6e0be-148e-4b59-9a7c-116bce192633__0001-SQOOP-2561.patch
> 
> 
> Thanks,
> 
> vishnu  s nair
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message