sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 47750: SQOOP-2867
Date Tue, 24 May 2016 03:40:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47750/#review134507
-----------------------------------------------------------



it looks like "all" is used by the client and the server. Perhaps we can move the constant
to a shared library (sqoop-common)?

- Abraham Fine


On May 24, 2016, 12:24 a.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47750/
> -----------------------------------------------------------
> 
> (Updated May 24, 2016, 12:24 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2867
>     https://issues.apache.org/jira/browse/SQOOP-2867
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> Sqoop2: ResTiliency: Define one single constant for all
> 
> 
> Diffs
> -----
> 
>   client/src/main/java/org/apache/sqoop/client/request/ConnectorResourceRequest.java
1556e34 
>   client/src/main/java/org/apache/sqoop/client/request/JobResourceRequest.java 5394493

>   client/src/main/java/org/apache/sqoop/client/request/LinkResourceRequest.java bf674df

>   client/src/main/java/org/apache/sqoop/client/request/RequestConstants.java PRE-CREATION

>   server/src/main/java/org/apache/sqoop/handler/AuthorizationRequestHandler.java 8d4d72b

>   server/src/main/java/org/apache/sqoop/handler/ConnectorRequestHandler.java c760689

>   server/src/main/java/org/apache/sqoop/handler/HandlerConstants.java PRE-CREATION 
>   server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java c86f8f0 
>   server/src/main/java/org/apache/sqoop/handler/LinkRequestHandler.java b44ae87 
>   server/src/main/java/org/apache/sqoop/handler/SubmissionRequestHandler.java 06c4478

> 
> Diff: https://reviews.apache.org/r/47750/diff/
> 
> 
> Testing
> -------
> 
> Run integration tests.
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message