sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Abraham Fine <...@abrahamfine.com>
Subject Re: Review Request 48100: Sqoop2: Provide option to re-create target directory if it exists in HDFS connector
Date Fri, 03 Jun 2016 20:23:41 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48100/#review136103
-----------------------------------------------------------


Fix it, then Ship it!





test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java (line
38)
<https://reviews.apache.org/r/48100/#comment201109>

    nit-pick: please do not use * imports


- Abraham Fine


On June 3, 2016, 8:09 p.m., Boglarka Egyed wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48100/
> -----------------------------------------------------------
> 
> (Updated June 3, 2016, 8:09 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2941
>     https://issues.apache.org/jira/browse/SQOOP-2941
> 
> 
> Repository: sqoop-sqoop2
> 
> 
> Description
> -------
> 
> A new option has been implemented to re-create target directory if it exists in HDFS
connector
> 
> 
> Diffs
> -----
> 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/HdfsToInitializer.java
70e0fde 
>   connector/connector-hdfs/src/main/java/org/apache/sqoop/connector/hdfs/configuration/ToJobConfig.java
d76ba5f 
>   connector/connector-hdfs/src/main/resources/hdfs-connector-config.properties 29efced

>   connector/connector-hdfs/src/test/java/org/apache/sqoop/connector/hdfs/TestToInitializer.java
5441702 
>   test/src/test/java/org/apache/sqoop/integration/connector/hdfs/OutputDirectoryTest.java
330da56 
> 
> Diff: https://reviews.apache.org/r/48100/diff/
> 
> 
> Testing
> -------
> 
> Integration tests have been extended and executed.
> 
> 
> Thanks,
> 
> Boglarka Egyed
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message