sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <asz...@cloudera.com>
Subject Re: Review Request 49192: OraOop does not close connections properly
Date Fri, 01 Jul 2016 13:17:55 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/49192/#review140341
-----------------------------------------------------------


Ship it!




Hey Szabi,

That's exactly what I was looking for. I think now we have got a proper test coverage so we
can ship it!

Thanks for you contribution!

- Attila Szabo


On June 30, 2016, 6:39 a.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/49192/
> -----------------------------------------------------------
> 
> (Updated June 30, 2016, 6:39 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2971
>     https://issues.apache.org/jira/browse/SQOOP-2971
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Connections are now closed properly in OraOopDataDrivenDBInputFormat class.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormat.java 13f05d5

>   src/java/org/apache/sqoop/mapreduce/db/DBInputFormat.java 3a8e5d0 
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java 50f3192 
>   src/test/org/apache/sqoop/manager/oracle/OraOopDataDrivenDBInputFormatConnectionCloseTest.java
PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/49192/diff/
> 
> 
> Testing
> -------
> 
> We have started an import job on a cluster with a patched Sqoop version and we have verified
that 1 map task now uses only 1 Oracle connection.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message