sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From David Robson <david.rob...@quest.com>
Subject Re: Review Request 50155: SQOOP-2983: OraOop export has degraded performance with wide tables
Date Tue, 23 Aug 2016 08:10:17 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50155/#review146489
-----------------------------------------------------------



The tests now work for me. This patch definitely makes the quoting issue a lot worse than
it currently is on trunk. A lot of tables that used to work now can no longer be exported
to at all.
I guess just to get this patch out of the way we could commit it and raise the quoting issue
as a separate issue?
This patch also currently breaks update exports completely - I tried various combinations
and could not get any scenarios to work that work on trunk. I believe it is again related
to the quoting issue as the following is put in the output:

"records were skipped due to a NULL value within one of the update-key column(s)."

Which is to do with OraOopOutputFormatUpdate line 390 I believe:

Object updateKeyValue = fieldMap.get(updateColumnName);

But it works if I run the same test on trunk but not with this patch.

- David Robson


On Aug. 19, 2016, 3:50 a.m., Attila Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50155/
> -----------------------------------------------------------
> 
> (Updated Aug. 19, 2016, 3:50 a.m.)
> 
> 
> Review request for Sqoop, David Robson, Jarek Cecho, and Kathleen Ting.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Proposed changes for SQOOP-2983
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 216c771 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java 6b27bd8 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatBase.java 8f94cf8 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatInsert.java d5eebf4 
>   src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatUpdate.java a33768f 
>   src/java/org/apache/sqoop/manager/oracle/OraOopUtilities.java e81588c 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 9d91887 
>   src/test/org/apache/sqoop/manager/oracle/ExportTest.java 991b221 
>   src/test/org/apache/sqoop/manager/oracle/OraOopTestCase.java 9fe4821 
>   src/test/org/apache/sqoop/manager/oracle/OraOopTypesTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/oracle/OraOopUpdateKeyTest.java PRE-CREATION 
>   src/test/org/apache/sqoop/manager/oracle/util/OracleData.java 8846f65 
> 
> Diff: https://reviews.apache.org/r/50155/diff/
> 
> 
> Testing
> -------
> 
> 800 columns with table
> 100.000 lines (156mb data)
> 1.000.000 lines (1.56 GB data)
> 3.000.000 lines (4.5 GB data)
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message