sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Venkat Ranganathan <n....@live.com>
Subject Re: Review Request 51854: Sqoop should not allow --as-parquetfile when job type is hcatalog
Date Tue, 13 Sep 2016 19:02:12 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51854/#review148761
-----------------------------------------------------------



+1 otherwise.   Please fix the indentations


src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 1596)
<https://reviews.apache.org/r/51854/#comment216273>

    Minor nit:   Sqoop uses 2 space indentation by default   Can you maintain that


- Venkat Ranganathan


On Sept. 13, 2016, 11:55 a.m., Sowmya Ramesh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51854/
> -----------------------------------------------------------
> 
> (Updated Sept. 13, 2016, 11:55 a.m.)
> 
> 
> Review request for Sqoop and Venkat Ranganathan.
> 
> 
> Bugs: SQOOP-3010
>     https://issues.apache.org/jira/browse/SQOOP-3010
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> sqoop import ... --create-hcatalog-table --hcatalog-table --as-parquetfile
> 
> 
> Error: java.lang.RuntimeException: Should never be used
>        	at org.apache.hadoop.hive.ql.io.parquet.MapredParquetOutputFormat.getRecordWriter(MapredParquetOutputFormat.java:76)
>        	at org.apache.hive.hcatalog.mapreduce.FileOutputFormatContainer.getRecordWriter(FileOutputFormatContainer.java:103)
>         
> This should not run and should display a validation error as it does for both --as-sequencefile
and --as-avrodatafile but the job runs and fails later with RuntimeException
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java fecdf43 
>   src/test/org/apache/sqoop/hcat/TestHCatalogBasic.java 5cd4c26 
> 
> Diff: https://reviews.apache.org/r/51854/diff/
> 
> 
> Testing
> -------
> 
> UTs added
> 
> 
> Thanks,
> 
> Sowmya Ramesh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message