sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <asz...@cloudera.com>
Subject Re: Review Request 52605: ClassWriter fails if a column name contains a backslash character
Date Fri, 07 Oct 2016 00:01:23 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52605/#review151739
-----------------------------------------------------------



Very nice work Szabi!

Good idea to use an existing escaping solution from a truested open source library, and also
you'd provided nice improvements around testing too.

- Attila Szabo


On Oct. 6, 2016, 3:01 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52605/
> -----------------------------------------------------------
> 
> (Updated Oct. 6, 2016, 3:01 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3021
>     https://issues.apache.org/jira/browse/SQOOP-3021
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-2864 solved this problem for the double quote character I generalized that solution.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 9d91887 
>   src/test/com/cloudera/sqoop/ThirdPartyTests.java 3103bd4 
>   src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java b5b9b6e 
>   src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 8dddd02 
>   src/test/org/apache/sqoop/manager/mysql/MySqlColumnEscapeImportTest.java PRE-CREATION

>   src/test/org/apache/sqoop/manager/oracle/OracleColumnEscapeImportTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/52605/diff/
> 
> 
> Testing
> -------
> 
> I have added a new MySQL third party test to test the escaping of the double quote character
in the column name and a new Oracle third party test to test the escaping of the backslash
character.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message