sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <asz...@cloudera.com>
Subject Re: Review Request 52426: row key not added into column family using --hbase-bulkload
Date Fri, 07 Oct 2016 13:26:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52426/#review151787
-----------------------------------------------------------



Hi Szabi,

The general idea behind this solution seems to be correct. Also the solution seems to be valid
for the first shot.
However I was not able to run the HBaseImportAddRowKeyTest with your changes successfully
(it's hanging in an infinite state).
I also checked that test without your changes and seems to have the very same effect.
I suspect here the HBase version in the upstream ivy.xml is older than the version you'd tested
with, and thus I'd like to kindly suggest you to deliver a fixed version where both the before/after
states are running with a successful state.
I would like to ask you also to double check if the scenario with asking Zookeeper to open
an arbitrary port is right and sustainable.

Regardless these things, I'm pretty sure this modification will work, you just need to invest
a bit more on the testing/validation front.

Many thanks in advance!
Attila

p.s.: If you deliver a new verison, could you please also ensure that the order of the dependencies
are unchanged? Thanks!

- Attila Szabo


On Sept. 30, 2016, 2:53 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52426/
> -----------------------------------------------------------
> 
> (Updated Sept. 30, 2016, 2:53 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2952
>     https://issues.apache.org/jira/browse/SQOOP-2952
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> row key not added into column family using --hbase-bulkload
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java b2431ac 
>   src/java/org/apache/sqoop/hbase/PutTransformer.java 8d6bcac 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java b5cad1d 
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 363b5d7 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java cfbb1d3 
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 37dc004 
> 
> Diff: https://reviews.apache.org/r/52426/diff/
> 
> 
> Testing
> -------
> 
> New unit test cases are added.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message