sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <asz...@cloudera.com>
Subject Re: Review Request 52426: row key not added into column family using --hbase-bulkload
Date Thu, 13 Oct 2016 12:38:08 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52426/#review152486
-----------------------------------------------------------


Ship it!




Hi Szabi,

Thanks so much for the update, it seems to work on my side either.
+1 for creating the JIRA tickets for cleaning up the profiles, especially because unittesting+3rd_party_testing
with different profiles (without clean) could cause unexpected behaviours/errors (I'd run
into that already even with your changeset). So I kindly ask you to create those iteams on
issues.apache.org as a follwup of this issue.

A big +1 for using DDT tools of JUnit.

Nice and clean solution!

- Attila Szabo


On Oct. 10, 2016, 1:42 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52426/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2016, 1:42 p.m.)
> 
> 
> Review request for Sqoop and Attila Szabo.
> 
> 
> Bugs: SQOOP-2952
>     https://issues.apache.org/jira/browse/SQOOP-2952
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> row key not added into column family using --hbase-bulkload
> 
> 
> Diffs
> -----
> 
>   build.xml 97e5502 
>   ivy.xml a502530 
>   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java b2431ac 
>   src/java/org/apache/sqoop/hbase/PutTransformer.java 8d6bcac 
>   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java b5cad1d 
>   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java 363b5d7 
>   src/test/com/cloudera/sqoop/hbase/HBaseImportAddRowKeyTest.java cfbb1d3 
>   src/test/com/cloudera/sqoop/hbase/HBaseTestCase.java 37dc004 
> 
> Diff: https://reviews.apache.org/r/52426/diff/
> 
> 
> Testing
> -------
> 
> New unit test cases are added.
> 
> HBaseImportAddRowKeyTest can be run with the following command:
> 
> ant clean test -Dtestcase=HBaseImportAddRowKeyTest -Dhadoopversion=260 -Dhbaseprofile=95
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message