sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <asz...@cloudera.com>
Subject Re: Review Request 50566: Add validation check for --hive-import and --incremental lastmodified
Date Thu, 13 Oct 2016 13:24:11 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/50566/#review152491
-----------------------------------------------------------


Ship it!




Nice job Szabi!

+1 for using @Rule feature, makes the unittets much more concise and declarative.

Keep up the good work!

- Attila Szabo


On Oct. 13, 2016, 1:11 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/50566/
> -----------------------------------------------------------
> 
> (Updated Oct. 13, 2016, 1:11 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-2986
>     https://issues.apache.org/jira/browse/SQOOP-2986
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Add validation check for --hive-import and --incremental lastmodified
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java b71bc5e 
>   src/test/org/apache/sqoop/tool/ImportToolValidateOptionsTest.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/50566/diff/
> 
> 
> Testing
> -------
> 
> New unit test cases are added, also tested manually by executing sqoop import command.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message