sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Anna Szonyi <szo...@cloudera.com>
Subject Re: Review Request 52212: SQOOP-3013: Configuration "tmpjars" is not checked for empty strings before passing to MR
Date Thu, 20 Oct 2016 09:56:24 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52212/#review153371
-----------------------------------------------------------




src/java/org/apache/sqoop/mapreduce/JobBase.java (line 209)
<https://reviews.apache.org/r/52212/#comment222664>

    Do we only want to check for empty strings? Would it make sense to check for whitespaces
using .isBlank() instead?



src/test/org/apache/sqoop/mapreduce/TestJobBase.java (lines 38 - 41)
<https://reviews.apache.org/r/52212/#comment222662>

    Should remove this header



src/test/org/apache/sqoop/mapreduce/TestJobBase.java (line 45)
<https://reviews.apache.org/r/52212/#comment222666>

    instead of using a boolean I might separate this method into two methods that verify on
an error and one that verifies the "success" case to make it more obvious.



src/test/org/apache/sqoop/mapreduce/TestJobBase.java (line 53)
<https://reviews.apache.org/r/52212/#comment222667>

    Would it make sense to refactor this into several methods based on the comments to make
it more obvious which parts are the setup steps and which are the validations/assertions?



src/test/org/apache/sqoop/mapreduce/TestJobBase.java (lines 70 - 74)
<https://reviews.apache.org/r/52212/#comment222665>

    This part could maybe be simplified by extracting the "warning" "logic" and potentially
verifying on its parameters.


Hey Liz,

Thanks for the patch, this is great, I just have a few minor comments :), please check and
see if it makes sense to incorporate them.

/Anna

- Anna Szonyi


On Oct. 19, 2016, 3:16 p.m., Erzsebet Szilagyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/52212/
> -----------------------------------------------------------
> 
> (Updated Oct. 19, 2016, 3:16 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Chris Teoh, Attila Szabo, Anna Szonyi, and
Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3013
>     https://issues.apache.org/jira/browse/SQOOP-3013
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> When setting job configurations and adding files to "tmpjars", Sqoop does not sanitize
the list of empty strings.
> Sqoop should remove empty strings before starting the MR job and raise a warning if an
empty string was found.
> 
> The proposed changes check for empty strings in "tmpjars" and remove them along with
raising a warning.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/JobBase.java 7ed2684 
>   src/test/org/apache/sqoop/mapreduce/TestJobBase.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/52212/diff/
> 
> 
> Testing
> -------
> 
> - Live test with command including: "tmpjars=,,valid,,,validother,,,"
> - Unit tests
> 
> 
> Thanks,
> 
> Erzsebet Szilagyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message