sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <mau...@apache.org>
Subject Re: Review Request 53374: SQOOP-3038 export to table with "value" column causes all null values in the "value" column
Date Tue, 08 Nov 2016 18:12:13 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53374/#review155318
-----------------------------------------------------------


Ship it!




Hey Anna,

It's a very nice finding, in case of a column called "value" it would just to the identity
"value = value" and not the right operation.
Also nice job around testing, and considering options around quoting!

Way to go!

- Attila Szabo


On Nov. 3, 2016, 10:17 a.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53374/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 10:17 a.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3038
>     https://issues.apache.org/jira/browse/SQOOP-3038
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3038 export to table with "value" column causes all null values in the "value"
column
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/orm/ClassWriter.java 2f14b6e 
>   src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 8aa0725 
>   src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java f4b1ea9 
> 
> Diff: https://reviews.apache.org/r/53374/diff/
> 
> 
> Testing
> -------
> 
> ran tests, created a new test to cover the "value" column case
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message