sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 53423: SQOOP-2349 Transaction isolation level for metadata queries should be mutable
Date Thu, 10 Nov 2016 13:53:44 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53423/#review155574
-----------------------------------------------------------



Hi Attila,

Thank you for the modifications, it looks great now, I have found only a couple of unused
imports/constants which need to be removed.


src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 25)
<https://reviews.apache.org/r/53423/#comment225563>

    It seems that this import was added but it is not actually used. Can we remove it?



src/java/org/apache/sqoop/tool/BaseSqoopTool.java (line 61)
<https://reviews.apache.org/r/53423/#comment225564>

    Since the enum is introduced the TRANSCATION_* constants are not needed anymore I think.


- Szabolcs Vasas


On Nov. 8, 2016, 4:33 p.m., Attila Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53423/
> -----------------------------------------------------------
> 
> (Updated Nov. 8, 2016, 4:33 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Abraham Fine, Boglarka Egyed, Anna Szonyi,
Szabolcs Vasas, and Erzsebet Szilagyi.
> 
> 
> Bugs: SQOOP-2349
>     https://issues.apache.org/jira/browse/SQOOP-2349
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> I've introduced a cmd line parameter for being able to set the metadata transaction levels
(defined on java.sql.Connection) manually if necessary. The change is backward compatible,
so by default SQOOP gonna still use READ_COMMITTED.
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/SqoopOptions.java e14a0b7 
>   src/java/org/apache/sqoop/manager/SqlManager.java 768507b 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 13a9697 
>   src/java/org/apache/sqoop/tool/JDBCTransactionLevels.java PRE-CREATION 
>   src/test/org/apache/sqoop/tool/TestImportTool.java PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/53423/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Attila Szabo
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message