sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <mau...@apache.org>
Subject Re: Review Request 54030: SQOOP-3055 MySQL tests are failing due to the tests ignoring specified username, password and dbname, trying to connect to specified db using "currentUser"
Date Tue, 29 Nov 2016 10:56:02 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54030/#review157220
-----------------------------------------------------------


Fix it, then Ship it!





src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java (lines 9 - 11)
<https://reviews.apache.org/r/54030/#comment227747>

    Could we please remove this, and stick to the standard formatting of the Apache License
header?


Hi Anna,

The changes looks goood. I've only found one tiny problem around a license header? Could you
please fix that?

Otherwise it looks good!

- Attila Szabo


On Nov. 25, 2016, 11:02 a.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54030/
> -----------------------------------------------------------
> 
> (Updated Nov. 25, 2016, 11:02 a.m.)
> 
> 
> Review request for Sqoop and Attila Szabo.
> 
> 
> Bugs: SQOOP-3055
>     https://issues.apache.org/jira/browse/SQOOP-3055
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3055 MySQL tests are ignoring specified username, password and dbname, trying to
connect to specified db using currentuser (using System.getEnv("USER") or whoami). You should
now be able to specify the user (and will have to when running Mysql tests), password, hostname
and database name for the MSQL tests (and they won't ignore it and use current users anymore).
> 
> 
> Diffs
> -----
> 
>   build.xml 6e8d393 
>   src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java 79e90e2 
>   src/test/com/cloudera/sqoop/manager/DirectMySQLTest.java d0f0c50 
>   src/test/com/cloudera/sqoop/manager/JdbcMySQLExportTest.java 86b9aab 
>   src/test/com/cloudera/sqoop/manager/MySQLAllTablesTest.java bad3c29 
>   src/test/com/cloudera/sqoop/manager/MySQLCompatTest.java 675b6b8 
>   src/test/com/cloudera/sqoop/manager/MySQLFreeFormQueryTest.java 935d948 
>   src/test/com/cloudera/sqoop/manager/MySQLLobAvroImportTest.java df78142 
>   src/test/com/cloudera/sqoop/manager/MySQLTestUtils.java 0af79d6 
>   src/test/org/apache/sqoop/manager/mysql/MySqlCallExportTest.java 6bf939b 
>   src/test/org/apache/sqoop/manager/mysql/MySqlColumnEscapeImportTest.java 87cd389 
> 
> Diff: https://reviews.apache.org/r/54030/diff/
> 
> 
> Testing
> -------
> 
> Ran all MySQL tests with hadoopversion 260 and hbaseprofile 95: ant test -Dhadoopversion=260
-Dhbaseprofile=95 -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=3rdpartylibdir -Dsqoop.test.mysql.connectstring.host_url=mysqlhost
-Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message