sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <mau...@apache.org>
Subject Re: Review Request 54373: SQOOP-3066: Introduce an option + env variable to enable/disable SQOOP-2737 feature
Date Mon, 05 Dec 2016 19:09:21 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54373/
-----------------------------------------------------------

(Updated Dec. 5, 2016, 7:09 p.m.)


Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet
Szilagyi.


Changes
-------

Removing outdated+unneccessary comment


Bugs: SQOOP-3066
    https://issues.apache.org/jira/browse/SQOOP-3066


Repository: sqoop-trunk


Description
-------

After SQOOP-2737 several users faced errors with their saved job configurations. Although
SQOOP-2737 is the proper and industrial way to handle table/column names, it makes sense to
implement an option for this feature to make it possible to turn it on/off


Diffs (updated)
-----

  src/java/org/apache/sqoop/SqoopOptions.java 2350c7a 
  src/java/org/apache/sqoop/manager/OracleManager.java d769972 
  src/java/org/apache/sqoop/manager/oracle/OraOopConnManager.java 216c771 
  src/java/org/apache/sqoop/manager/oracle/OraOopDBRecordReader.java f3ee4aa 
  src/java/org/apache/sqoop/manager/oracle/OraOopOracleQueries.java 2603f83 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatBase.java 8f94cf8 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatInsert.java d430ef7 
  src/java/org/apache/sqoop/manager/oracle/OraOopOutputFormatUpdate.java a33768f 
  src/java/org/apache/sqoop/manager/oracle/OracleUtils.java b46034b 
  src/java/org/apache/sqoop/mapreduce/db/OracleDBRecordReader.java f1647b8 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 6082296 
  src/test/com/cloudera/sqoop/TestSqoopOptions.java d5d09b6 
  src/test/org/apache/sqoop/manager/oracle/util/OracleData.java 355b1e2 

Diff: https://reviews.apache.org/r/54373/diff/


Testing
-------

additional test cases has been created
ant clean test


Thanks,

Attila Szabo


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message