sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <mau...@apache.org>
Subject Re: Review Request 54427: SQOOP-3071: Fix OracleManager to apply localTimeZone correctly in case of Date objects too
Date Tue, 06 Dec 2016 16:14:39 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 6, 2016, 4:14 p.m.)

Review request for Sqoop, Abraham Fine, Boglarka Egyed, Anna Szonyi, Szabolcs Vasas, and Erzsebet


Default fallback scenario (GMT) has been improved

Bugs: SQOOP-3071

Repository: sqoop-trunk


In the current implementation OraOop and OracleManager are different from the POV of setting
sessionTimeZone in oracle.
OracleManager does not set the TimeZone in java, and neither the default timeZone on the Oracle
Thus when the local timezone realted data is retrieved by Sqoop as not a String object, but
as a Date, the timeZone information is lost, and this could cause confusion/bogus behaviour
on user side.
The goal is to get inline the two implementation.

Diffs (updated)

  src/java/org/apache/sqoop/manager/OracleManager.java 3273435e 

Diff: https://reviews.apache.org/r/54427/diff/


OracleManagerTest#testOracleImport now executes successfully in all circumstances


Attila Szabo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message