sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Attila Szabo <mau...@apache.org>
Subject Re: Review Request 54540: SQOOP-3074: Fix Avro import not to fail with Javac errors in case of non UTF-8 locale
Date Thu, 08 Dec 2016 21:53:20 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated Dec. 8, 2016, 9:53 p.m.)

Review request for Sqoop and Anna Szonyi.


Comments had been added.

Bugs: SQOOP-3074

Repository: sqoop-trunk


The current implementation of Sqoop will fail to compile the ClassWriter generated Java class
in case of UTF-8 characters are available in the database but the running host don't have
UTF-8 or not supporting that.
Meanwhile we'd like to keep up the support of UTF-8 characters for example in Avro schemas.
A good example for that TestAvroImport#testNonstandardCharactersInColumnName fails if executed
form a shell/env with non UTF-8 locale.
We have to provide an implementation reflects this.

Diffs (updated)

  src/java/org/apache/sqoop/avro/AvroUtil.java ee29f140 
  src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java 3c31c43a 
  src/java/org/apache/sqoop/orm/ClassWriter.java 6f6e66b5 

Diff: https://reviews.apache.org/r/54540/diff/


ant clean test

ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=/root -Dsqoop.test.mysql.connectstring.host_url=jdbc:mysql://mysqlhostname/
-Dsqoop.test.mysql.databasename=sqoop_repo -Dsqoop.test.mysql.password=sqoop -Dsqoop.test.mysql.username=sqoop
-Dsqoop.test.oracle.connectstring=jdbc:oracle:thin:@//oraclehostname/orcl -Dsqoop.test.postgresql.connectstring.host_url=jdbc:postgresql://postgreshostname/
-Dsqoop.test.cubrid.connectstring.host_url=jdbc:cubrid:cubridhotname:33000 -Dsqoop.test.cubrid.connectstring.username=sqoop
-Dsqoop.test.cubrid.connectstring.database=sqoop -Dsqoop.test.cubrid.connectstring.password=sqoop
-Dmapred.child.java.opts="-Djava.security.egd=file:/dev/../dev/urandom" -Dtest.timeout=1000000


Attila Szabo

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message