sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hudson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (SQOOP-3075) Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining explicit locales instead of using EscapeUtils
Date Fri, 16 Dec 2016 11:25:59 GMT

    [ https://issues.apache.org/jira/browse/SQOOP-3075?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15754173#comment-15754173
] 

Hudson commented on SQOOP-3075:
-------------------------------

SUCCESS: Integrated in Jenkins build Sqoop-hadoop200 #1087 (See [https://builds.apache.org/job/Sqoop-hadoop200/1087/])
SQOOP-3075: Simplify Unicode character support in source files (maugli: [https://git-wip-us.apache.org/repos/asf?p=sqoop.git&a=commit&h=be30a344ee28ae60fcce9e9e45a0ec73c93209a7])
* (edit) src/java/org/apache/sqoop/orm/ClassWriter.java
* (edit) src/java/org/apache/sqoop/orm/CompilationManager.java
* (edit) src/java/org/apache/sqoop/avro/AvroUtil.java
* (edit) src/java/org/apache/sqoop/orm/AvroSchemaGenerator.java


> Simplify Unicode character support in source files (introduced by SQOOP-3074) by defining
explicit locales instead of using EscapeUtils
> ---------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: SQOOP-3075
>                 URL: https://issues.apache.org/jira/browse/SQOOP-3075
>             Project: Sqoop
>          Issue Type: Improvement
>            Reporter: Attila Szabo
>            Assignee: Attila Szabo
>         Attachments: SQOOP-3075.patch
>
>
> Although [SQOOP-3074] achieved that Sqoop won't fail anymore with special characters
even if the locale on the caller system is not UTF-8, there's a simpler solution to do the
same thing, by tuning the compiler + classwriter itself (by adding explicit encodings) instead
of using the StringEscapeUtils#escapeJava mechanism.
> This solution seems simpler, and won't introduce any confusion around generation of Java
identifiers.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message