sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 55132: support for DB2 XML data type when importing to hdfs
Date Thu, 23 Feb 2017 12:23:29 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55132/#review166509
-----------------------------------------------------------



Hi Ying,

Thank you for the patch! I think the code you added works correctly, however there are a few
minor things need to be fixed. See my comments below.

Regards,
Szabolcs


src/java/org/apache/sqoop/manager/Db2Manager.java (line 53)
<https://reviews.apache.org/r/55132/#comment238469>

    I think this constant should have a more expressive name, as it contains the Java type
the XML type is mapped to.



src/java/org/apache/sqoop/manager/Db2Manager.java (line 131)
<https://reviews.apache.org/r/55132/#comment238470>

    Can we move this field declaration above the constructor? That would be inline with Java
code style.



src/java/org/apache/sqoop/manager/Db2Manager.java (line 168)
<https://reviews.apache.org/r/55132/#comment238471>

    I am not sure the debug message would be correct here. The keySet() method returns a set
which is not necessarily ordered, so the debug message can be misleading.



src/java/org/apache/sqoop/manager/Db2Manager.java (line 175)
<https://reviews.apache.org/r/55132/#comment238472>

    You use startsWith instead of equals here. Do we have more XML data types?



src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java (line 213)
<https://reviews.apache.org/r/55132/#comment238473>

    The test looks good to me, however then I try to run it it fails, because test.build.data
does not seem to be defined on my machine. Can you please fix it?


- Szabolcs Vasas


On Feb. 9, 2017, 3:39 a.m., Ying Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55132/
> -----------------------------------------------------------
> 
> (Updated Feb. 9, 2017, 3:39 a.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek and Jarek Cecho.
> 
> 
> Bugs: SQOOP-1904
>     https://issues.apache.org/jira/browse/SQOOP-1904
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-1904: support for DB2 XML data type when importing to hdfs
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java e39aa4c 
>   src/test/org/apache/sqoop/manager/db2/DB2XmlTypeImportManualTest.java PRE-CREATION

> 
> Diff: https://reviews.apache.org/r/55132/diff/
> 
> 
> Testing
> -------
> 
> UT passed by manually
> 
> 
> Thanks,
> 
> Ying Cao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message