sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <egyedb...@gmail.com>
Subject Re: Review Request 56984: SQOOP-3139: change default of mapreduce.map.maxattempts to 1 for import (so it's consistent with export)
Date Thu, 23 Feb 2017 15:02:25 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56984/#review166525
-----------------------------------------------------------


Fix it, then Ship it!




Hi Anna,

Thanks for this fix, I got a very minor finding, please find it below.

Thanks,
Bogi


src/java/org/apache/sqoop/mapreduce/ImportJobBase.java (line 350)
<https://reviews.apache.org/r/56984/#comment238481>

    Please correct "export" here to "import".


- Boglarka Egyed


On Feb. 23, 2017, 1:56 p.m., Anna Szonyi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56984/
> -----------------------------------------------------------
> 
> (Updated Feb. 23, 2017, 1:56 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, Szabolcs Vasas, and Liz Szilagyi.
> 
> 
> Bugs: SQOOP-3139
>     https://issues.apache.org/jira/browse/SQOOP-3139
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3139: sqoop tries to re-execute select query during import in case of a connection
reset error and this is causing lots of duplicate records from source
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/ImportJobBase.java 105917c 
> 
> Diff: https://reviews.apache.org/r/56984/diff/
> 
> 
> Testing
> -------
> 
> ant test
> 
> 
> Thanks,
> 
> Anna Szonyi
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message