sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eric Lin <eric....@cloudera.com>
Subject Re: Review Request 57551: SQOOP-2272 - Import decimal columns from mysql to hive 0.14
Date Tue, 28 Mar 2017 04:35:32 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/57551/
-----------------------------------------------------------

(Updated March 28, 2017, 4:35 a.m.)


Review request for Sqoop, Attila Szabo and Szabolcs Vasas.


Changes
-------

Changes based on Attila's review suggestions.


Repository: sqoop-trunk


Description
-------

Currently Sqoop converts DECIMAL from RDMS into DOUBLE in Hive, which is not correct as user
will lose precisions. Since Hive supports DECIMAL long ago, we should support DECIMAL to DECIMAL
conversion from Sqoop to Hive.


Diffs (updated)
-----

  src/java/org/apache/sqoop/hive/HiveTypes.java ad00535 
  src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 
  src/test/com/cloudera/sqoop/hive/TestHiveImport.java 33e0cc4 
  src/test/com/cloudera/sqoop/hive/TestTableDefWriter.java dbf0dde 
  testdata/hive/scripts/decimalImport.q PRE-CREATION 


Diff: https://reviews.apache.org/r/57551/diff/5/

Changes: https://reviews.apache.org/r/57551/diff/4-5/


Testing
-------

Test case + maunaul test


Thanks,

Eric Lin


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message