sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jilani Shaik <jilani2...@gmail.com>
Subject Re: Review Request 57499: Sqoop incremental import - NULL column updates are not pulled into HBase table
Date Tue, 21 Mar 2017 05:03:14 GMT
Hi Bogi,

When I am doing

ant -Dthirdparty=true test

I am getting error while initiating the minihbase cluster.

I am working on windows system from cmd line.

2017-03-20 23:47:59,643 (main) [ERROR -
org.apache.hadoop.hbase.MiniHBaseCluster.init(MiniHBaseCluster.java:233)]
Error starting cluster
java.lang.RuntimeException: Failed construction of Master: class
org.apache.hadoop.hbase.master.HMasterIllegal character in authority at
index 7:
file://C:\Users\arfu1\AppData\Local\Temp\29d3fccc-b968-4ed1-84f3-651277bba0ca\hbase


I am attaching the test result file for the same. Please let me know what
is missing here.

Thanks,
Jilani

On Sun, Mar 19, 2017 at 6:24 AM, Boglarka Egyed <egyedbogi@gmail.com> wrote:

>
>
> > On March 18, 2017, 11:06 a.m., Boglarka Egyed wrote:
> > > Hi Jilani,
> > >
> > > Thanks for your contribution!
> > >
> > > I have applied your patch and got some warnings because of the
> incorrect indentation and trailing whitespaces which I mentioned in my
> review below too, please find my further findings there too. I could run
> 'ant clean test' susseccfully with your patch.
> > >
> > > On the top of the findings, could you please add a test case for your
> change?
> > >
> > > Thanks,
> > > Bogi
>
> Hi Jilani,
>
> I think you could add test(s) to com.cloudera.sqoop.hbase.HBaseImportNullTest
> class as it tests the null import into HBase cases.
>
> Thanks,
> Bogi
>
>
> - Boglarka
>
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/57499/#review169361
> -----------------------------------------------------------
>
>
> On March 11, 2017, 6:16 a.m., Jilani Shaik wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/57499/
> > -----------------------------------------------------------
> >
> > (Updated March 11, 2017, 6:16 a.m.)
> >
> >
> > Review request for Sqoop.
> >
> >
> > Bugs: SQOOP-3149
> >     https://issues.apache.org/jira/browse/SQOOP-3149
> >
> >
> > Repository: sqoop-trunk
> >
> >
> > Description
> > -------
> >
> > HBase delete is added as part of incremental data import, Modified the
> return type of method which is responsible for holding list of Put objects
> to List of Mutation objects and at the time of execution of insert or
> delete using the type of object in Mutation, executed the actaul operation
> either insert or delete.
> >
> > Jira ticket for the same: https://issues.apache.org/
> jira/browse/SQOOP-3149
> >
> > Similar ticket to above:  SQOOP-3125
> >
> >
> > Diffs
> > -----
> >
> >   src/java/org/apache/sqoop/hbase/HBasePutProcessor.java fdbe1276
> >   src/java/org/apache/sqoop/hbase/PutTransformer.java 533467e5
> >   src/java/org/apache/sqoop/hbase/ToStringPutTransformer.java 363e1456
> >   src/java/org/apache/sqoop/mapreduce/HBaseBulkImportMapper.java
> 58ccee7b
> >
> >
> > Diff: https://reviews.apache.org/r/57499/diff/1/
> >
> >
> > Testing
> > -------
> >
> > Executed with jar prepared with these changes into hadoop cluster and
> tested bot import and then incremental import.
> >
> >
> > File Attachments
> > ----------------
> >
> > HBase delete support for incremental import
> >   https://reviews.apache.org/media/uploaded/files/2017/03/
> 11/5b1895fd-4c6b-42fa-8a92-4e093153e370__hbase_delete_
> support_in_incremental_import
> >
> >
> > Thanks,
> >
> > Jilani Shaik
> >
> >
>
>

Mime
View raw message