sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 51912: SQOOP 816 - Scoop and support for external Hive tables
Date Wed, 26 Apr 2017 12:52:55 GMT

This is an automatically generated e-mail. To reply, visit:

(Updated April 26, 2017, 12:52 p.m.)

Review request for Sqoop, Kathleen Ting, Attila Szabo, and Liz Szilagyi.


Addressed the issues around NPEs and added some more unit tests.

Repository: sqoop-trunk


SQOOP-816 - Hive External table support. Added --as-external-table option and --table-location

Diffs (updated)

  src/java/org/apache/sqoop/SqoopOptions.java 801942e 
  src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 
  src/java/org/apache/sqoop/tool/BaseSqoopTool.java 46f405f 
  src/test/org/apache/sqoop/hive/TestTableDefWriter.java PRE-CREATION 
  src/test/org/apache/sqoop/tool/TestImportTool.java 7e11f54 

Diff: https://reviews.apache.org/r/51912/diff/6/

Changes: https://reviews.apache.org/r/51912/diff/5-6/


Unit tests.
Interactive IDE debug step throughs.
No testing on HiveServer as SQOOP-2787 may not yet be in trunk.
End to end testing on PostgresQL to HiveServer performed.


Chris Teoh

  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message