sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@cloudera.com>
Subject Re: Including SQLServer Manual tests into 3rd party test suite
Date Wed, 19 Apr 2017 10:00:07 GMT
Thank you very much for your input!

I have created a JIRA <https://issues.apache.org/jira/browse/SQOOP-3174>
for it and I will proceed with it according to this discussion.

Many thanks,
Bogi

On Fri, Apr 14, 2017 at 5:17 PM, <jarcec@apache.org> wrote:

> That is a good question Bogi!
>
> I’m not sure if anyone is running all the third party tests at the moment
> as I’m not closely monitoring the community any more. Historically I’ve
> always added new DB to the third party test suite to make sure that they
> will actually run or by failing fast will tell the dev who is running them
> there there is a new piece of integration that needs additional testing.
>
> It seems that nobody in the past 4 days jumped in saying that it’s a
> concern, so I would recommend going ahead and adding the MS SQL tests to
> 3rd party test suite. Since it’s a test code and not any production
> deliverable, we can always iterate if that will turn out to be a problem in
> the future.
>
> Jarcec
>
> > On Apr 10, 2017, at 8:19 AM, Boglarka Egyed <bogi@cloudera.com> wrote:
> >
> > Hi All,
> >
> > I would like to start a discussion about including the SQLServer Manual
> > tests to the 3rd party test suite. I think this would bring a huge
> > improvement as these tests are currently executed very rarely or even
> never
> > (as several test cases are failing, DB connection string and credentials
> > are hard coded in the code, etc.) and not bringing too much value. Adding
> > them to the 3rd party test suite would help to keep Sqoop more robust as
> > these could be executed in case of any related code change easily.
> >
> > However, this would mean that every contributor who wants to run 3rd
> party
> > tests on their machine should have an SQLServer instance to avoid having
> > bothering failures. Having such instances installed manually for MySQL,
> > Postgres, Oracle and Cubrid is already required for running this test
> > suite. Since Sqoop also supports SQLServer and DB2 I would say that it
> > would be reasonable to create such requirements for having these SQL
> server
> > instances too in order to execute an extended 3rd part test suite.
> >
> > Please share your thoughts on this topic, every input is welcome.
> >
> > Thanks,
> > Bogi
> >
> > P.s.: Running 3rd party test on the CI making them fully automated is
> > another question raised in another email thread on dev@
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message