sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ying Cao <angela.caoy...@gmail.com>
Subject Re: Review Request 58477: support DB2 xml data type when sqoop import with parquet
Date Mon, 15 May 2017 02:02:49 GMT


> On 五月 1, 2017, 4:59 p.m., Boglarka Egyed wrote:
> > Hi Ying,
> > 
> > I ran DB2XmlTypeParquetImportManualTest test case added by you and it failed with
[ERROR -org.apache.sqoop.Sqoop.runSqoop(Sqoop.java:185)] Got exception running Sqoop: java.lang.IllegalArgumentException:
Cannot convert SQL type 2009
> > 
> > Could you please review your change?
> > 
> > I also left two minor comments on your patch.
> > 
> > Thanks,
> > Bogi

Hi Bogi,

Thanks a lot for your review. I have update patch with fix of your comments, please help to
review it again, thanks!


By the way I used command "ant clean -Dtestcase=DB2XmlTypeParquetImportManualTest  test" to
run UT, build successed


- Ying


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58477/#review173471
-----------------------------------------------------------


On 五月 8, 2017, 7:35 a.m., Ying Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58477/
> -----------------------------------------------------------
> 
> (Updated 五月 8, 2017, 7:35 a.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-3173
>     https://issues.apache.org/jira/browse/SQOOP-3173
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-3173 : support DB2 xml data type when sqoop import with parquet
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/ConnManager.java 1811ce0 
>   src/test/org/apache/sqoop/manager/db2/DB2XmlTypeParquetImportManualTest.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/58477/diff/3/
> 
> 
> Testing
> -------
> 
> UT passed by manually
> 
> This is third-part test, I ran it by :
> 
> ant clean test -Dthirdparty=true -Dsqoop.thirdparty.lib.dir=3rdparty -Dsqoop.test.db2.connectstring.host_url=connectstring
-Dsqoop.test.db2.connectstring.database=databasename -Dsqoop.test.db2.connectstring.username=username
-Dsqoop.test.db2.connectstring.password=password -Dtestcase=DB2XmlTypeParquetImportManualTest
> 
> 
> Thanks,
> 
> Ying Cao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message