sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Chris Teoh <chris.t...@gmail.com>
Subject Re: Review Request 51912: SQOOP 816 - Scoop and support for external Hive tables
Date Mon, 15 May 2017 09:46:25 GMT


> On May 13, 2017, 8:51 a.m., Anna Szonyi wrote:
> > Hi Chris,
> > 
> > Thanks for the NPE fixes! Unfortunately I don't see the test class src/test/org/apache/sqoop/hive/TestTableDefWriter.java
in the current revision (7). Could you please add that back in? Also it generally makes it
easier if you name the patches including the revisions (SQOOP-816-7.patch), as it's easier
to track what you downloaded and applied and what changed between the versions.
> > 
> > As a side note (again this is not a must), but do you think you could include the
Postgres E2E test you were running (maybe extending HiveImportTest or the PostgresqlImportTests).
> > 
> > Apologies for the latency on this, this is a great, super useful feature and we
want to make sure it gets committed with all the necessary classes/features!
> > 
> > Thanks,
> > Anna

Thanks for reviewing Anna, and apologies for missing that file. I thought I had it included
but I must have missed it when working with new files and git. :)

I have updated the diff for now and will see how I can build the E2E test, I tried last time
but the dependencies in the project didn't seem to be compatible and I wasn't sure if it would
break the existing integration tests.


- Chris


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51912/#review174891
-----------------------------------------------------------


On April 30, 2017, 7:48 a.m., Chris Teoh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51912/
> -----------------------------------------------------------
> 
> (Updated April 30, 2017, 7:48 a.m.)
> 
> 
> Review request for Sqoop, Kathleen Ting, Attila Szabo, and Liz Szilagyi.
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-816 - Hive External table support. Added --as-external-table option and --table-location
option
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/SqoopOptions.java 801942e 
>   src/java/org/apache/sqoop/hive/TableDefWriter.java 32fcca3 
>   src/java/org/apache/sqoop/tool/BaseSqoopTool.java 46f405f 
>   src/test/org/apache/sqoop/tool/TestImportTool.java 7e11f54 
> 
> 
> Diff: https://reviews.apache.org/r/51912/diff/7/
> 
> 
> Testing
> -------
> 
> Unit tests.
> Interactive IDE debug step throughs.
> No testing on HiveServer as SQOOP-2787 may not yet be in trunk.
> End to end testing on PostgresQL to HiveServer performed.
> 
> 
> Thanks,
> 
> Chris Teoh
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message