sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <egyedb...@gmail.com>
Subject Re: Review Request 58600: add --schema option for import-all-tables and list-tables against db2
Date Mon, 05 Jun 2017 11:09:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/#review176905
-----------------------------------------------------------


Fix it, then Ship it!




Hi Angela,

Build and ant clean test were successful with your patch.

I have left one last finding, please correct it before committing this change.

Thanks for your contribution!

Cheers,
Bogi


src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java
Lines 76 (patched)
<https://reviews.apache.org/r/58600/#comment250457>

    Please use ManualTest at the end so that the related ant task for manual tests will find
it.


- Boglarka Egyed


On June 4, 2017, 4:38 p.m., Ying Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58600/
> -----------------------------------------------------------
> 
> (Updated June 4, 2017, 4:38 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo,
and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-1905
>     https://issues.apache.org/jira/browse/SQOOP-1905
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef 
>   src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5 
>   src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManual.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/58600/diff/3/
> 
> 
> Testing
> -------
> 
> Mannual UT  is passed
> 
> 
> Thanks,
> 
> Ying Cao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message