sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Review Request 59831: HCatalogExportTest fails because of column escaping problems
Date Tue, 06 Jun 2017 10:04:19 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59831/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3194
    https://issues.apache.org/jira/browse/SQOOP-3194


Repository: sqoop-trunk


Description
-------

org.apache.sqoop.hcat.HCatalogTestUtils#assertSqlColValForRowId: the colname should be always
escaped, since this is the approach taken in the creation SQL command as well in org.apache.sqoop.hcat.HCatalogTestUtils#getSqlCreateTableStatement.


Diffs
-----

  src/test/org/apache/sqoop/hcat/HCatalogExportTest.java 32add56 
  src/test/org/apache/sqoop/hcat/HCatalogTestUtils.java 4301a33 


Diff: https://reviews.apache.org/r/59831/diff/1/


Testing
-------

I ran all the Sqoop tests (unit tests and third party tests) with the patch.


Thanks,

Szabolcs Vasas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message