sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Review Request 59844: Database credentials cannot be configured in PostgreSQL third party tests
Date Tue, 06 Jun 2017 16:59:57 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59844/
-----------------------------------------------------------

Review request for Sqoop.


Bugs: SQOOP-3197
    https://issues.apache.org/jira/browse/SQOOP-3197


Repository: sqoop-trunk


Description
-------

PostgreSQL third party tests look like they support configurable database parameters (e.g.
they load the database user, name and password from a system property) but the property names
in the test cases do not match the property names in the build.xml and because of that these
parameters cannot be specified from the command line.


Diffs
-----

  build.xml af43c47 
  src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java 38d6ba6 
  src/test/com/cloudera/sqoop/manager/PostgresqlExternalTableImportTest.java 0515e09 
  src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 5872d25 


Diff: https://reviews.apache.org/r/59844/diff/1/


Testing
-------

Ran unit and third party test cases.


Thanks,

Szabolcs Vasas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message