sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <egyedb...@gmail.com>
Subject Re: Review Request 59843: Modify MySQLAuthTest to use configurable test database parameters
Date Thu, 08 Jun 2017 17:45:36 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59843/#review177333
-----------------------------------------------------------


Fix it, then Ship it!




Thanks Szabi for your contribution!

I ran unit and third party tests with your patch successfully.

I have left a minor finding, please correct it.

Thanks,
Bogi


src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java
Lines 50-66 (original)
<https://reviews.apache.org/r/59843/#comment250877>

    Could you please provide a guideline here for running this test?


- Boglarka Egyed


On June 6, 2017, 4:36 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59843/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 4:36 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3196
>     https://issues.apache.org/jira/browse/SQOOP-3196
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> Most of the MySQL third party test cases use MySQLTestUtils to get the test database
parameters because these parameters can be configured using system properties.
> One exception is MySQLAuthTest which uses a predefined database name, username and password
which cannot be configured. 
> The goal of this JIRA is to change MySQLAuthTest to use MySQLTestUtils since it would
make setting up a new test database easier and make the MySQL third party test suite more
consistent.
> 
> 
> After changing MySQLAuthTest to use MySQLTestUtils I realized that MySQLAllTablesTest
was failing because MySQLAuthTest did not drop all the tables it created so I needed to modify
it to make sure all the created tables are dropped. I did not want to add more code duplication
to this test class so I did some refactoring on it before addig the extra drop logic.
> 
> 
> Diffs
> -----
> 
>   src/test/com/cloudera/sqoop/manager/DirectMySQLExportTest.java ec7b84a 
>   src/test/com/cloudera/sqoop/manager/MySQLAuthTest.java d5cca5d 
>   src/test/com/cloudera/sqoop/testutil/BaseSqoopTestCase.java 6310a39 
> 
> 
> Diff: https://reviews.apache.org/r/59843/diff/1/
> 
> 
> Testing
> -------
> 
> Executed unit and third party test cases.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message