sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <egyedb...@gmail.com>
Subject Re: Review Request 59844: Database credentials cannot be configured in PostgreSQL third party tests
Date Thu, 08 Jun 2017 18:04:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59844/#review177344
-----------------------------------------------------------


Ship it!




Thanks for catching this, Szabi!

I ran unit ant Postgres third party tests successfully with your patch.

Thanks,
Bogi

- Boglarka Egyed


On June 6, 2017, 4:59 p.m., Szabolcs Vasas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59844/
> -----------------------------------------------------------
> 
> (Updated June 6, 2017, 4:59 p.m.)
> 
> 
> Review request for Sqoop.
> 
> 
> Bugs: SQOOP-3197
>     https://issues.apache.org/jira/browse/SQOOP-3197
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> PostgreSQL third party tests look like they support configurable database parameters
(e.g. they load the database user, name and password from a system property) but the property
names in the test cases do not match the property names in the build.xml and because of that
these parameters cannot be specified from the command line.
> 
> 
> Diffs
> -----
> 
>   build.xml af43c47 
>   src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java 38d6ba6 
>   src/test/com/cloudera/sqoop/manager/PostgresqlExternalTableImportTest.java 0515e09

>   src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 5872d25 
> 
> 
> Diff: https://reviews.apache.org/r/59844/diff/1/
> 
> 
> Testing
> -------
> 
> Ran unit and third party test cases.
> 
> 
> Thanks,
> 
> Szabolcs Vasas
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message