sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ying Cao <angela.caoy...@gmail.com>
Subject Re: Review Request 58600: add --schema option for import-all-tables and list-tables against db2
Date Mon, 12 Jun 2017 03:21:37 GMT


> On 五月 24, 2017, 3:15 p.m., Boglarka Egyed wrote:
> > Hi Ying,
> > 
> > I tried to run 'ant clean test' with your patch but ran into some compilation errors.
Please find the details below.
> > 
> > Thanks,
> > Bogi
> 
> Attila Szabo wrote:
>     Hey Bogi,
>     
>     Thanks for checking, and catching these issues!
>     
>     Angela! Please also fix the issues what Bogi raised, and around the logging you could
also consider to do some generalization (as I can see you're using LoggingUtils and the Logger
itself in a kinda mixed way, depending you your personal preferences it would be nice, to
use only one of these ways for logging).
>     
>     Thanks,
>     Attila

Hi Attila,

I have fix issues Bogi raised, thanks Bogi detials. The manual test is passed 

And I have make some updates use loggingUtils to pop-up SQLException, Logger for others.


> On 五月 24, 2017, 3:15 p.m., Boglarka Egyed wrote:
> > src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchema.java
> > Lines 73 (patched)
> > <https://reviews.apache.org/r/58600/diff/2/?file=1731302#file1731302line73>
> >
> >     Could you please include "ManualTest" at the end of this test name to follow
the usual naming convention which is also used in the build.xml to create the manual test
suite?

Hi Bogi,

Thnaks for your comments

Angela


- Ying


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58600/#review175936
-----------------------------------------------------------


On 六月 5, 2017, 3:01 p.m., Ying Cao wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58600/
> -----------------------------------------------------------
> 
> (Updated 六月 5, 2017, 3:01 p.m.)
> 
> 
> Review request for Sqoop, Abraham Elmahrek, Boglarka Egyed, Jarek Cecho, Attila Szabo,
and Szabolcs Vasas.
> 
> 
> Bugs: SQOOP-1905
>     https://issues.apache.org/jira/browse/SQOOP-1905
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> SQOOP-1905 : add --schema option for import-all-tables and list-tables against db2
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/manager/Db2Manager.java 52ab05ef 
>   src/java/org/apache/sqoop/manager/GenericJdbcManager.java 2113a5f5 
>   src/test/org/apache/sqoop/manager/db2/DB2ImportAllTableWithSchemaManualTest.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/58600/diff/4/
> 
> 
> Testing
> -------
> 
> Mannual UT  is passed
> 
> 
> Thanks,
> 
> Ying Cao
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message