sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Szabolcs Vasas <vasas.szabo...@gmail.com>
Subject Re: Review Request 59844: Database credentials cannot be configured in PostgreSQL third party tests
Date Thu, 29 Jun 2017 17:08:53 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59844/
-----------------------------------------------------------

(Updated June 29, 2017, 5:08 p.m.)


Review request for Sqoop.


Changes
-------

Fixing DirectPostgreSQLExportManualTest


Bugs: SQOOP-3197
    https://issues.apache.org/jira/browse/SQOOP-3197


Repository: sqoop-trunk


Description
-------

PostgreSQL third party tests look like they support configurable database parameters (e.g.
they load the database user, name and password from a system property) but the property names
in the test cases do not match the property names in the build.xml and because of that these
parameters cannot be specified from the command line.


Diffs (updated)
-----

  build.xml 2903b7d146e3c4f18bc46f52a2945b59fa789f4c 
  src/test/com/cloudera/sqoop/manager/DirectPostgreSQLExportManualTest.java 52095ef296449c0c2bcce2653c5e797c222b5e20

  src/test/com/cloudera/sqoop/manager/PostgresqlExportTest.java 38d6ba69da062907a89536727bd9b4c4d0cd1903

  src/test/com/cloudera/sqoop/manager/PostgresqlExternalTableImportTest.java 0515e098a870635628f4ea34cc4340292eab9744

  src/test/com/cloudera/sqoop/manager/PostgresqlImportTest.java 5872d259475d017074d67ffac266fdb48e59c4b7



Diff: https://reviews.apache.org/r/59844/diff/2/

Changes: https://reviews.apache.org/r/59844/diff/1-2/


Testing
-------

Ran unit and third party test cases.


Thanks,

Szabolcs Vasas


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message