sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sandish Kumar HN <sanysand...@gmail.com>
Subject Re: Review Request 59346: SQOOP-3178 : Incremental Merging for Parquet File Format
Date Wed, 19 Jul 2017 16:13:24 GMT


> On July 19, 2017, 3:30 p.m., Boglarka Egyed wrote:
> > Hi Sandish,
> > 
> > On the top of Anna's findings I have one more, general comment on your patch. Otherwise
I ran the unit tests with your change successfully. Could you please address my question below?
> > 
> > Thanks,
> > Bogi

Hi Boglarka Egyed,

Thanks for finding issues. You findings makes sense. I think I maybe followed AvroMergeJob
one. Anyways Thanks.


- Sandish Kumar


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59346/#review180927
-----------------------------------------------------------


On July 19, 2017, 4:08 p.m., Sandish Kumar HN wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59346/
> -----------------------------------------------------------
> 
> (Updated July 19, 2017, 4:08 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed, Attila Szabo, and Szabolcs Vasas.
> 
> 
> Bugs: PARQUET-1010 and SQOOP-3178
>     https://issues.apache.org/jira/browse/PARQUET-1010
>     https://issues.apache.org/jira/browse/SQOOP-3178
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> New feature for sqoop-1: Sqoop Merge and Incremental Merge for Parquet File Format
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/MergeGenericRecordExportMapper.java PRE-CREATION

>   src/java/org/apache/sqoop/mapreduce/MergeJob.java 8b1cba33 
>   src/java/org/apache/sqoop/mapreduce/MergeParquetMapper.java PRE-CREATION 
>   src/java/org/apache/sqoop/mapreduce/MergeParquetReducer.java PRE-CREATION 
>   src/java/org/apache/sqoop/tool/ImportTool.java 78c7758e 
>   src/test/com/cloudera/sqoop/TestMerge.java 114e934a 
> 
> 
> Diff: https://reviews.apache.org/r/59346/diff/10/
> 
> 
> Testing
> -------
> 
> Hi,
> 
>  I have written a Sqoop Merge and Incremental Merge MR for Parquet File Format and I
have tested with million records of data with N number of iterations. Please review My patch.
> 
> THIS ISSUE HAS DEPENDANCY ON PARQUET BUG. SO I HAVE RESOLVED THE PARQUET ISSUE AND CREATED
A PATCH FOR IT HERE https://issues.apache.org/jira/browse/PARQUET-1010
> 
> Please let me know if there are any mistakes in My patch
> 
> 
> Thanks,
> 
> Sandish Kumar HN
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message