sqoop-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Boglarka Egyed <b...@apache.org>
Subject Re: Review Request 62057: SQOOP-3014 Sqoop with HCatalog import loose precision for large numbers that does not fit into double
Date Tue, 05 Sep 2017 16:57:49 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62057/#review184557
-----------------------------------------------------------



Hi Zoltan,

Thank you for this fix!

Could you please add an integration test too where you perform an actual sqoop import testing
the specific cases? Check out HCatalogImportTest for example.

Thanks,
Bogi

- Boglarka Egyed


On Sept. 5, 2017, 3:32 p.m., Zoltán Tóth wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62057/
> -----------------------------------------------------------
> 
> (Updated Sept. 5, 2017, 3:32 p.m.)
> 
> 
> Review request for Sqoop, Boglarka Egyed and Anna Szonyi.
> 
> 
> Bugs: SQOOP-3014
>     https://issues.apache.org/jira/browse/SQOOP-3014
> 
> 
> Repository: sqoop-trunk
> 
> 
> Description
> -------
> 
> HCatalog rounded BigDecimals but that should not happen. Now Sqoop HCatalog doesn't change
BigDecimals
> 
> 
> Diffs
> -----
> 
>   src/java/org/apache/sqoop/mapreduce/hcat/SqoopHCatImportHelper.java aba2458e 
>   src/test/org/apache/sqoop/mapreduce/hcat/TestSqoopHCatImportHelper.java PRE-CREATION

> 
> 
> Diff: https://reviews.apache.org/r/62057/diff/1/
> 
> 
> Testing
> -------
> 
> I ran unit tests and integration tests as well. New test cases were added to test the
change
> 
> 
> Thanks,
> 
> Zoltán Tóth
> 
>


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message